Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure Trusted Signing #683

Closed
EuanKerr opened this issue Apr 29, 2024 · 10 comments
Closed

Support for Azure Trusted Signing #683

EuanKerr opened this issue Apr 29, 2024 · 10 comments
Labels
enhancement Product code improvement that does NOT require public API changes/additions Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@EuanKerr
Copy link

With Azure Trusted Signing (formerly Azure Code Signing) now in public preview it would be handy to be able to sign files/clickonce using the Trusted Signing service.

Some more links:

@clairernovotny clairernovotny added enhancement Product code improvement that does NOT require public API changes/additions Priority:1 Work that is critical for the release, but we could probably ship without labels Apr 29, 2024
@dlemstra
Copy link
Contributor

dlemstra commented May 8, 2024

Would love to see support for this. The @ImageMagick project has a Trusted Signing certificate and we are using this to sign our installers and executables. But there is no support for that in this tool yet. And I would like to also sign my ImageMagick NuGet packages using that certificate in a GitHub pipeline.

And feel free to let me know if there is anything I can do to help.

@blowdart
Copy link

blowdart commented May 9, 2024

Throwing my weight behind this as I have a new package I want to test with and I'm trying to keep everything in GitHub actions as an added bonus.

@ROGG437063
Copy link

I am also supporting this request, our developers need to migrate to trusted signing, but without support for clickonce in any of the other trusted signing tools, that is not possible.

@ROGG437063
Copy link

This integration should probably use the SDK https://www.nuget.org/packages/Microsoft.Trusted.Signing.Client
Do take care that the SDK linked in trusted signing docs is deprecated

@ianjmcm
Copy link

ianjmcm commented May 31, 2024

@ROGG437063 sorry for the confusion on the docs regarding the SDK. We have kept the current version from our preview unlisted while we prep a new release of the SDK. This SDK will become publicly listed in the very near future. https://www.nuget.org/packages/Azure.CodeSigning.Sdk
cc: @Jaxelr

@Jaxelr
Copy link
Member

Jaxelr commented Jun 1, 2024

@ROGG437063 Indeed, we expect the SDK to be publicly available once we sort through a few issues on the PR, but you can track that work here: Azure/azure-sdk-for-net#41191

@ROGG437063
Copy link

@Jaxelr Sounds good, any estimate of when that will be merged? It would also still need integration with sign cli for vsto manifest signing, right?

@demiliani
Copy link

Must to have. Please push 🙌🏻

@dtivel
Copy link
Collaborator

dtivel commented Jun 28, 2024

This prerelease version has Trusted Signing support. Thanks to @dlemstra for adding it! 👏

@mjcheetham
Copy link

This prerelease version has Trusted Signing support. Thanks to @dlemstra for adding it! 👏

This works great!

@dtivel dtivel closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Product code improvement that does NOT require public API changes/additions Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

10 participants