Skip to content

Remove ADP.IsEmpty() #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Remove ADP.IsEmpty() #3277

merged 1 commit into from
Apr 16, 2025

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Apr 15, 2025

No description provided.

@samsharma2700 samsharma2700 self-assigned this Apr 15, 2025
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 15, 2025

@samsharma2700 @mdaigle Could some start the CI?

@mdaigle
Copy link
Contributor

mdaigle commented Apr 15, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing stuff like this is very satisfying :)

@paulmedynski paulmedynski requested a review from a team April 16, 2025 10:54
@paulmedynski paulmedynski self-assigned this Apr 16, 2025
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cheenamalhotra cheenamalhotra added this to the 6.1-preview1 milestone Apr 16, 2025
@cheenamalhotra cheenamalhotra merged commit c5e3c40 into dotnet:main Apr 16, 2025
122 checks passed
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (aa35edc) to head (ad0b284).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...x/src/Microsoft/Data/SqlClient/SqlDataReaderSmi.cs 0.00% 6 Missing ⚠️
...fx/src/Microsoft/Data/Common/DBConnectionString.cs 25.00% 3 Missing ⚠️
...x/src/Microsoft/Data/Common/DbConnectionOptions.cs 80.00% 1 Missing ⚠️
...rc/Microsoft/Data/SqlClient/SqlClientPermission.cs 0.00% 1 Missing ⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs 87.50% 1 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aa35edc) and HEAD (ad0b284). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa35edc) HEAD (ad0b284)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
- Coverage   72.91%   66.26%   -6.66%     
==========================================
  Files         296      289       -7     
  Lines       57257    56901     -356     
==========================================
- Hits        41751    37704    -4047     
- Misses      15506    19197    +3691     
Flag Coverage Δ
addons ?
netcore 68.96% <100.00%> (-6.15%) ⬇️
netfx 65.26% <73.46%> (-6.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants