Skip to content

Conversation

edwardneal
Copy link
Contributor

Description

This ports #3623 to the release/6.1 branch. It's as described in the original PR.

Issues

Fixes #3595.

Testing

I've re-run the manual test and confirmed the fix operates in v6.1.

@edwardneal edwardneal requested a review from a team as a code owner September 23, 2025 17:32
@paulmedynski
Copy link
Contributor

/azp run

@paulmedynski paulmedynski self-assigned this Sep 23, 2025
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@David-Engel David-Engel changed the title Port | PR #3623 to release/6.1 [6.1] Fix | Improve error handling when creating performance counters Sep 23, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.96%. Comparing base (7a7b54e) to head (474928e).
⚠️ Report is 12 commits behind head on release/6.1.

Files with missing lines Patch % Lines
...oft/Data/SqlClient/Diagnostics/SqlClientMetrics.cs 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7a7b54e) and HEAD (474928e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7a7b54e) HEAD (474928e)
addons 1 0
Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.1    #3629      +/-   ##
===============================================
- Coverage        69.69%   59.96%   -9.74%     
===============================================
  Files              281      273       -8     
  Lines            62413    61431     -982     
===============================================
- Hits             43500    36837    -6663     
- Misses           18913    24594    +5681     
Flag Coverage Δ
addons ?
netcore 61.84% <ø> (-10.92%) ⬇️
netfx 63.95% <66.66%> (-5.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle self-assigned this Sep 24, 2025
@paulmedynski paulmedynski merged commit 7dd31ee into dotnet:release/6.1 Sep 25, 2025
236 checks passed
@edwardneal edwardneal deleted the port/pr-3623/release-6.1 branch September 25, 2025 11:23
@paulmedynski paulmedynski added this to the 6.1.2 milestone Oct 3, 2025
@paulmedynski paulmedynski linked an issue Oct 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Diagnostics.PerformanceCounter.InitializeImpl() error
3 participants