Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor explicitly requested package identifier during uninstall #4613

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

JanKrivanek
Copy link
Member

Problem

Fixes #4156
Remote feed packages could not be unistalled when unistall command run from local folder with subfolder of clashing name

Solution

The package identifier requested to be unistalled is checked first as is only then expanded for wildcards or local folders. If any package found - it's uninstalled and no error is logged

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@JanKrivanek JanKrivanek requested a review from a team as a code owner April 19, 2022 15:02
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not actionable:

just to restate dislike for current ExpandMaskedPath logic.
I feel like path expansion should be done much later likely after it is determined that the package is folder.

Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only small concern that likely DetermineSourcesToUninstallAsync needs better modularization now (likely needed before).

@JanKrivanek JanKrivanek merged commit 806e7eb into dotnet:main Apr 27, 2022
@JanKrivanek JanKrivanek deleted the uninstall-clash-fix branch April 27, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to uninstall template
2 participants