Design proposal for interactive invocation #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uple open questions
This was referenced Jan 31, 2023
donJoseLuis
previously requested changes
Feb 2, 2023
|
I like it! |
JanKrivanek
reviewed
Feb 24, 2023
|
|
||
| ## Workflow | ||
|
|
||
| When a user invokes a template, the command should evaluate the user-provided parameters and determine if it should enter interactive mode. This is done by checking if the command is being invoked from a terminal (i.e. isatty is true) and if the command has any symbols that are of type `parameter` and are required _while also having required symbols that are not explicitly provided_. If both of these conditions are true, the command should enter interactive mode. |
There was a problem hiding this comment.
This sounds very reasonable. Below in Detecting interactive mode, there is only the explicit opt-in option.
Do we want implicit switch to interactive mode under the conditions outlined here as well? Or not for the initial version?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proposed design doc for interactive invocation to open it up for discussion. I've focused on the invocation scenario for now - there are enough open questions to discuss that will likely take a bit to work through.
Need more details on