Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change official builds to use platform-specific VSIXs #4852

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

gregg-miskelly
Copy link
Contributor

This PR hopefully completes the work to switch to platform-specific VSIXs. This renames the gulp tasks to give better names and changes the official builds to use the new tasks.

This PR hopefully completes the work to switch to platform-specific VSIXs. This renames the gulp tasks to give better names and changes the official builds to use the new tasks.
@gregg-miskelly gregg-miskelly linked an issue Oct 28, 2021 that may be closed by this pull request
@gregg-miskelly
Copy link
Contributor Author

gregg-miskelly commented Oct 28, 2021

@JoeRobich have you seen either of these failures before?

The first failure is because OmnisharpProjectDiagnosticStatus.message.ProjectFilePath was null

  1) OmnisharpReferenceProvider: sln with several csproj's
       "before all" hook for "Returns the reference without declaration":
     Uncaught TypeError: Cannot read property 'replace' of null
      at t.call [as _next] (src/observers/BackgroundWorkStatusBarObserver.ts:17:74)
      at t.__tryOrUnsub (node_modules/rxjs/_esm5/internal/Subscriber.js:192:16)
      at t.next (node_modules/rxjs/_esm5/internal/Subscriber.js:130:22)
      at t._next (node_modules/rxjs/_esm5/internal/Subscriber.js:76:26)
      at t.next (node_modules/rxjs/_esm5/internal/Subscriber.js:53:18)
      at t.next (node_modules/rxjs/_esm5/internal/Subject.js:47:25)
      at t.EventStream.post (src/EventStream.ts:16:19)
      at EventEmitter.<anonymous> (src/omnisharp/server.ts:307:30)
      at k._fireEvent (src/omnisharp/server.ts:248:24)
      at k._handleEventPacket (src/omnisharp/server.ts:738:18)
      at k._onLineReceived (src/omnisharp/server.ts:703:22)
      at Interface._onLine (readline.js:337:10)
      at Interface._normalWrite (readline.js:482:12)
      at Socket.ondata (readline.js:194:10)
      at addChunk (internal/streams/readable.js:309:12)
      at readableAddChunk (internal/streams/readable.js:284:9)
      at Socket.Readable.push (internal/streams/readable.js:223:10)
      at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)


  2) OmnisharpReferenceProvider: sln with several csproj's
       "before all" hook for "Returns the reference without declaration":
     Error: done() called multiple times in hook <OmnisharpReferenceProvider: sln with several csproj's "before all" hook for "Returns the reference without declaration"> of file /home/runner/work/omnisharp-vscode/omnisharp-vscode/out/test/integrationTests/referenceProvider.test.js
      at processTicksAndRejections (internal/process/task_queues.js:93:5)

@JoeRobich
Copy link
Member

@JoeRobich have you seen either of these failures before?

It does seem that our integration tests are in a season of flakiness. I can make time to take a closer look.

@gregg-miskelly
Copy link
Contributor Author

It does seem that our integration tests are in a season of flakiness. I can make time to take a closer look.

Thanks! I kicked off a test checkin to make sure it really isn't from the offline change: #4854

@gregg-miskelly gregg-miskelly merged commit b43193c into dotnet:master Oct 28, 2021
@gregg-miskelly gregg-miskelly deleted the PlatformSpecificCI branch October 28, 2021 22:01
@JoeRobich
Copy link
Member

JoeRobich commented Oct 28, 2021

@vzarytovskii @nohwnd With this change we will now have multiple platform specific vsixs to publish to the marketplace instead of a single vsix. See https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.17-beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement platform-specific extensions
2 participants