Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DuplexChannelFactory<TChannel> constructor with Type overloads #5167

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Expose DuplexChannelFactory<TChannel> constructor with Type overloads #5167

merged 2 commits into from
Jul 3, 2023

Conversation

imcarolwang
Copy link
Contributor

For #5159 .

@imcarolwang imcarolwang marked this pull request as ready for review May 24, 2023 11:06
@HongGit
Copy link
Contributor

HongGit commented May 30, 2023

@imcarolwang can you please add one E2E test to validate the callback instance is created correctly and functions?

@HongGit HongGit requested a review from mconnew June 20, 2023 03:39
@imcarolwang imcarolwang merged commit f424f6f into dotnet:main Jul 3, 2023
8 checks passed
@imcarolwang imcarolwang deleted the issue5159 branch December 14, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HongGit HongGit HongGit approved these changes

@mconnew mconnew Awaiting requested review from mconnew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imcarolwang @HongGit