Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo fails to restore deleted TabControl in TableLayoutPanel in DemoConsole application #11628

Closed
Syareel-Sukeri opened this issue Jul 4, 2024 · 5 comments
Assignees
Labels
💥 regression-preview Regression from a preview release
Milestone

Comments

@Syareel-Sukeri
Copy link
Contributor

Syareel-Sukeri commented Jul 4, 2024

.NET version

.NET 9.0: Main branch of WinForms repo (.NET 9.0.100-preview.7.24353.17)

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, this is a regression issue. Not repro on .NET 9.0.0-preview.5.24306.7

Issue description

In DemoConsole test app of Winforms repo, undo process of deleting TableLayoutPanel contained TabControl does not work properly. TabControl disappears after clicking Undo a few times

TabControlTableLayout.mp4

Steps to reproduce

Test sample: DemoConsole in Winforms repo

More Info

  1. The issue cannot be reproduced when other controls are in the TableLayoutPanel.
  2. When moving controls within TableLayoutPanel and using undo, it takes up to 3 clicks to restore the original state.
UndoLocation.mp4
  1. Reproduce the same result when using Ctrl+Z to undo.
@Syareel-Sukeri Syareel-Sukeri added the untriaged The team needs to look at this issue in the next triage label Jul 4, 2024
@Syareel-Sukeri Syareel-Sukeri changed the title Deleted TableLayoutPanel contained TabControl cannot be undo in DemoConsole application Undo fails to restore deleted TabControl in TableLayoutPanel in DemoConsole application Jul 4, 2024
@Syareel-Sukeri Syareel-Sukeri changed the title Undo fails to restore deleted TabControl in TableLayoutPanel in DemoConsole application Undo fails to restore deleted TabControl and TableLayoutPanel in DemoConsole application Jul 4, 2024
@Syareel-Sukeri Syareel-Sukeri changed the title Undo fails to restore deleted TabControl and TableLayoutPanel in DemoConsole application Undo fails to restore deleted TabControl in TableLayoutPanel in DemoConsole application Jul 4, 2024
@Syareel-Sukeri Syareel-Sukeri added the 💥 regression-preview Regression from a preview release label Jul 4, 2024
@merriemcgaw merriemcgaw added this to the Future milestone Jul 9, 2024
@JeremyKuhne
Copy link
Member

Possibly BinaryFormatter related?

@JeremyKuhne JeremyKuhne self-assigned this Jul 16, 2024
@lonitra
Copy link
Member

lonitra commented Jul 16, 2024

Could also be same root cause as #11657

@LeafShi1 LeafShi1 removed the untriaged The team needs to look at this issue in the next triage label Jul 24, 2024
@LeafShi1
Copy link
Member

This issue disappear after add binary Formatter package in DemoConsole project (Related PR #11741)

@LeafShi1 LeafShi1 assigned LeafShi1 and unassigned JeremyKuhne Jul 24, 2024
@lonitra
Copy link
Member

lonitra commented Jul 24, 2024

We're dependent on BinaryFormatter for CodeDomSerialization and adding the package fixes the issue

@lonitra lonitra closed this as completed Jul 24, 2024
@Olina-Zhang
Copy link
Member

Verified this issue on winforms repo from main branch, it was fixed: undo process of deleting TableLayoutPanel contained TabControl successfully.

GH11628_Verify.mp4

@Olina-Zhang Olina-Zhang modified the milestones: Future, 9.0 Preview7 Jul 25, 2024
@MelonWang1 MelonWang1 modified the milestones: 9.0 Preview7, 9.0 RC1 Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💥 regression-preview Regression from a preview release
Projects
None yet
Development

No branches or pull requests

7 participants