Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary Formatter package to DemoConsole #11741

Merged

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 24, 2024

Fixes #11710

Proposed changes

  • Add binary Formatter package to DemoConsole.csproj

Customer Impact

  • The components control in the Democonsole application can be moved

Regression?

  • Yes

Risk

  • Mininal

Screenshots

Before

BinaryFormatter error when moving the components control in the Democonsole application

democonsole.mp4

After

The components control in the DemoConsole application can be moved normally

AfterChange

Test methodology

  • Manually

Test environment(s)

  • .net 9.0.0-preview.7.24371.6
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner July 24, 2024 02:41
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73400%. Comparing base (c0318e5) to head (f008b62).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11741         +/-   ##
===================================================
- Coverage   74.73622%   74.73400%   -0.00223%     
===================================================
  Files           3045        3045                 
  Lines         630638      630638                 
  Branches       46862       46862                 
===================================================
- Hits          471315      471301         -14     
- Misses        155957      155982         +25     
+ Partials        3366        3355         -11     
Flag Coverage Δ
Debug 74.73400% <ø> (-0.00223%) ⬇️
integration 17.96290% <ø> (+0.01864%) ⬆️
production 47.75407% <ø> (-0.00387%) ⬇️
test 96.98447% <ø> (-0.00087%) ⬇️
unit 44.77120% <ø> (-0.03368%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Jul 24, 2024
@LeafShi1 LeafShi1 force-pushed the Issue_11710_Fix_Add_BinaryFormatterPackage branch from 8629885 to 532a4ed Compare July 24, 2024 08:37
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 24, 2024
@lonitra lonitra merged commit c3cb9b3 into dotnet:main Jul 24, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot modified the milestones: .NET 9.0, 9.0 RC1 Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinaryFormatter error when moving the components control in the Democonsole application
3 participants