Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryFormatter error when moving the components control in the Democonsole application #11710

Closed
Nora-Zhou01 opened this issue Jul 19, 2024 · 4 comments · Fixed by #11741
Closed
Assignees
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Milestone

Comments

@Nora-Zhou01
Copy link
Member

.NET version

9.0.100-preview.7.24368.5

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, not repro in .NET 8.0, still reproduced in PR 11614

Issue description

In DemoConsole test app of Winforms repo's main branch, BinaryFormatter error when moving the components control in the Democonsole application
image

democonsole.mp4

Steps to reproduce

Test sample: DemoConsole in Winforms repo

@Nora-Zhou01 Nora-Zhou01 added untriaged The team needs to look at this issue in the next triage 💥 regression-preview Regression from a preview release area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization labels Jul 19, 2024
@elachlan
Copy link
Contributor

I am thinking the fix here will be to add a package reference to binary formatter.

@JeremyKuhne did the team want the codedomserializer to be binaryserializer only?

@JeremyKuhne
Copy link
Member

There really isn't much choice but to depend on BinaryFormatter for CodeDomSerializer

@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Jul 24, 2024
@Tanya-Solyanik
Copy link
Member

@LeafShi1 - please add the binary Formatter package to DemoConsole
https://www.nuget.org/packages/System.Runtime.Serialization.Formatters/9.0.0-preview.6.24327.7

<PackageReference Include="System.Runtime.Serialization.Formatters" Version="$(SystemRuntimeSerializationFormattersPackageVersion)" />

@Tanya-Solyanik Tanya-Solyanik removed the untriaged The team needs to look at this issue in the next triage label Jul 24, 2024
@LeafShi1 LeafShi1 self-assigned this Jul 24, 2024
@Syareel-Sukeri
Copy link
Contributor

Verified the issue on the latest DemoConsole test app of Winforms repo from main branch, it was fixed. No BinaryFormatter error appears when moving components control in DemoConsole application.

MovingComponentControl.mp4

@MelonWang1 MelonWang1 modified the milestones: .NET 9.0, 9.0 RC1 Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants