Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DomainUpDown #11331

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented May 8, 2024

related #10453

Proposed changes

  • Add unit tests for DomainUpDown to test DownButton and UpButton methods: Verify the behavior of the DownButton and UpButton methods in the DomainUpDown class and how they change the SelectedIndex under different conditions
  • Add unit test for DomainUpDown to test ToString method: Test ToString method's output, ensuring it correctly reflects the state of the Items collection and the SelectedIndex.

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 99.37107% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.38096%. Comparing base (c4596e2) to head (4d8d82c).
Report is 83 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11331         +/-   ##
===================================================
+ Coverage   74.22320%   74.38096%   +0.15775%     
===================================================
  Files           3021        3028          +7     
  Lines         626156      627666       +1510     
  Branches       46698       46764         +66     
===================================================
+ Hits          464753      466864       +2111     
+ Misses        158006      157453        -553     
+ Partials        3397        3349         -48     
Flag Coverage Δ
Debug 74.38096% <99.37107%> (+0.15775%) ⬆️
integration 17.98687% <ø> (-0.28269%) ⬇️
production 47.18868% <ø> (+0.30856%) ⬆️
test 96.98800% <99.37107%> (-0.05071%) ⬇️
unit 44.16941% <ø> (+0.33545%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels May 9, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label May 10, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 10, 2024
@LeafShi1
Copy link
Member

LGTM! @lonitra Please review this PR.

@LeafShi1 LeafShi1 requested a review from lonitra May 11, 2024 06:45
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label May 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 16, 2024
@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label May 16, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 29, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM!

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label May 31, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jun 4, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra enabled auto-merge (squash) June 4, 2024 16:08
@lonitra lonitra merged commit 481bb3d into dotnet:main Jun 4, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone Jun 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants