Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #11520 to fix a MenuItem issue. #11920

Merged

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Aug 19, 2024

Reverting this fixes #11909.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann self-assigned this Aug 19, 2024
@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner August 19, 2024 22:36
@elachlan
Copy link
Contributor

elachlan commented Aug 19, 2024

#11520 linking here so it's easier to find.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.01445%. Comparing base (c993d33) to head (e30cbbb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11920         +/-   ##
===================================================
+ Coverage   75.01033%   75.01445%   +0.00412%     
===================================================
  Files           3047        3047                 
  Lines         631621      631597         -24     
  Branches       46770       46766          -4     
===================================================
+ Hits          473781      473789          +8     
+ Misses        154482      154442         -40     
- Partials        3358        3366          +8     
Flag Coverage Δ
Debug 75.01445% <0.00000%> (+0.00412%) ⬆️
integration 17.93579% <0.00000%> (+0.00010%) ⬆️
production 48.12255% <0.00000%> (+0.00686%) ⬆️
test 97.01653% <ø> (ø)
unit 45.14770% <0.00000%> (+0.03229%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KlausLoeffelmann KlausLoeffelmann merged commit 43fc91e into dotnet:main Aug 19, 2024
8 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the RevertMenuItemA11YIssue branch August 19, 2024 23:12
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Aug 19, 2024
KlausLoeffelmann added a commit to KlausLoeffelmann/winforms that referenced this pull request Aug 20, 2024
KlausLoeffelmann added a commit to KlausLoeffelmann/winforms that referenced this pull request Aug 20, 2024
KlausLoeffelmann added a commit to KlausLoeffelmann/winforms that referenced this pull request Aug 20, 2024
KlausLoeffelmann added a commit that referenced this pull request Aug 20, 2024
Revert #11520 to fix a MenuItem issue. (#11920)
KlausLoeffelmann added a commit that referenced this pull request Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MenuStrip highlight "sticks" after menu item is activated, also affects keyboard focus
3 participants