Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC1/9.0] Backport MenuItemFix #11930

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Aug 20, 2024

Backport the Menu Item Fix (#11920) into .NET 9RC1 to fix #11909.

Since the original bug fix used Properties-APIs, which are not available in .NET 9RC/Rel, a few adjustments had to be made here.

Customer Impact:

The original A11Y PR introduced a breaking change, and it is specifically blocking Rick Brewster (the maintainer of Paint .NET) to migrate Paint.NET to .NET 9, which is another reason why I would like this to get in into RC1 already, to unblock all folks, who have been started to migrate to .NET 9 and are blocked by this.

Workaround: There is none.

Regression?

  • Yes from the previous release
  • No

Risk

  • High
  • Medium
  • Low –The changes are isolated and are not affecting anything else. This PR is effectively a revert of the A11Y PR, which needs a different approach. We are not considering the A11Y issue High Prio issue, so it can be addressed again in .NET 10.

Verification

  • Manual testing – Several manual tests made sure that this issue has been mitigated.
  • Automated
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.79469%. Comparing base (701b3b1) to head (58f15fd).
Report is 3 commits behind head on release/9.0-rc1.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           release/9.0-rc1      #11930         +/-   ##
=========================================================
- Coverage         74.79692%   74.79469%   -0.00223%     
=========================================================
  Files                 3019        3019                 
  Lines               630034      630010         -24     
  Branches             46781       46777          -4     
=========================================================
- Hits                471246      471214         -32     
- Misses              155411      155419          +8     
  Partials              3377        3377                 
Flag Coverage Δ
Debug 74.79469% <0.00000%> (-0.00223%) ⬇️
integration 18.03583% <0.00000%> (+0.00082%) ⬆️
production 47.78483% <0.00000%> (-0.00723%) ⬇️
test 97.00837% <ø> (ø)
unit 44.80782% <0.00000%> (-0.01063%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KlausLoeffelmann KlausLoeffelmann marked this pull request as ready for review August 20, 2024 05:34
@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner August 20, 2024 05:34
@Tanya-Solyanik Tanya-Solyanik added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 20, 2024
@lonitra lonitra modified the milestones: .NET 9.0, 9.0 RC1 Aug 20, 2024
@lonitra lonitra removed the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 20, 2024
@leecow leecow added the Servicing-approved .NET Shiproom approved the PR for merge label Aug 20, 2024
@KlausLoeffelmann KlausLoeffelmann changed the title Backport 9RC1 MenuItemFix [RC1/9.0] Backport MenuItemFix Aug 20, 2024
@KlausLoeffelmann KlausLoeffelmann merged commit 7d2b0e5 into dotnet:release/9.0-rc1 Aug 20, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants