Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] [RC2] Revert #11520 to fix a MenuItem issue #11931

Merged

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Aug 20, 2024

Backport the Menu Item Fix (#11920) into .NET 9RC1 to fix #11909.

MenuStrip highlight "sticks" after menu item is activated, also affects keyboard focus · Issue #11909 · dotnet/winforms (github.com)

Customer Impact

This is a breaking change, and it is specifically blocking Rick Brewster (the maintainer of Paint .NET) to migrate Paint.NET to .NET 9, which is another reason why I would like this to get in into RC1 already, to unblock all folks, who have been started to migrate to .NET 9 and are blocked by this.

Workaround: There is none.

Regression?

  • Yes from the previous release
  • [] No

Risk

  • High
  • Medium
  • Low –The changes are isolated and are not affecting anything else. This PR is effectively a revert of the A11Y PR, which needs a different approach. We are not considering the A11Y issue High Prio issue, so it can be addressed again in .NET 10.

Verification

  • Manual testing – Several manual tests made sure that this issue has been mitigated.
  • Automated
Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann added this to the .NET 9.0 milestone Aug 20, 2024
@KlausLoeffelmann KlausLoeffelmann self-assigned this Aug 20, 2024
@KlausLoeffelmann KlausLoeffelmann marked this pull request as ready for review August 20, 2024 05:34
@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner August 20, 2024 05:34
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.79167%. Comparing base (97322a7) to head (dd475b5).
Report is 1 commits behind head on release/9.0.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/9.0      #11931         +/-   ##
=====================================================
- Coverage     74.79485%   74.79167%   -0.00319%     
=====================================================
  Files             3019        3019                 
  Lines           630034      630010         -24     
  Branches         46781       46777          -4     
=====================================================
- Hits            471233      471195         -38     
- Misses          155425      155428          +3     
- Partials          3376        3387         +11     
Flag Coverage Δ
Debug 74.79167% <0.00000%> (-0.00319%) ⬇️
integration 18.03090% <0.00000%> (+0.00117%) ⬆️
production 47.77920% <0.00000%> (-0.00828%) ⬇️
test 97.00750% <ø> (-0.00088%) ⬇️
unit 44.80500% <0.00000%> (-0.00713%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik changed the title Backport 9Rel MenuItemFix [release/9.0] [RC2] Revert #11520 to fix a MenuItem issue Aug 20, 2024
@lonitra lonitra modified the milestones: .NET 9.0, 9.0 RC2 Aug 20, 2024
@KlausLoeffelmann KlausLoeffelmann merged commit 8cd1fac into dotnet:release/9.0 Aug 20, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants