-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hand.cur #2038
Merged
Merged
Remove hand.cur #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
===================================================
- Coverage 27.70556% 27.68644% -0.01913%
===================================================
Files 879 879
Lines 266701 266701
Branches 37945 37945
===================================================
- Hits 73891 73840 -51
- Misses 187585 187631 +46
- Partials 5225 5230 +5
|
RussKie
added
the
📬 waiting-for-testing
The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
label
Oct 8, 2019
Thank you, we'll have it merge once we get a sign off from the test team. |
Btw, it is considered an anti pattern to work off the master branch. You will find yourself in troubles attempting to |
RussKie
removed
the
📬 waiting-for-testing
The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
label
Oct 9, 2019
QA approved. |
RussKie
approved these changes
Oct 9, 2019
ghost
added this to the 5.0 milestone
Oct 9, 2019
RussKie
added
code cleanup
cleanup code for unused apis/properties/comments - no functional changes.
enhancement
Product code improvement that does NOT require public API changes/additions
labels
Oct 9, 2019
Thank you |
14 tasks
ghost
locked as resolved and limited conversation to collaborators
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
code cleanup
cleanup code for unused apis/properties/comments - no functional changes.
enhancement
Product code improvement that does NOT require public API changes/additions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140 (old fix was reverted due to broken tests, this PR doesn't adds any test)
Proposed changes
hand.cur
(supposedly) due to previously supporting OSes not havingIDC_HAND
.hand.cur
remains, and it looks terrible on high DPI screens as well as not respecting user cursor customization.Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
I did not test this change using Accessibility Insights, but I don't think this will affect accessibility negatively (it might even affect it positively, for people that require the use of different-colored or big cursors)
Test environment(s)
Microsoft Reviewers: Open in CodeFlow