Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup DataGridViewRow tests and add sync with DataGridViewColumn #3213

Merged
merged 1 commit into from
May 8, 2020
Merged

Cleanup DataGridViewRow tests and add sync with DataGridViewColumn #3213

merged 1 commit into from
May 8, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented May 5, 2020 •
edited by ghost
Loading

@hughbe hughbe requested a review from a team as a code owner May 5, 2020 13:54
@ghost ghost assigned hughbe May 5, 2020
@hughbe
Copy link
Contributor Author

hughbe commented May 5, 2020 •
edited
Loading

What I've done here is essentially remove any creation of controls in the MemberData enumerables and also align DataGridViewRow and DataGridViewColumn tests.

DataGridViewCellTests remains a problem but I sadly have these things called finals to be revising for in the next few hours :((

@hughbe hughbe force-pushed the Cleanup-DataGridViewRow-Tests branch 2 times, most recently from fcc2d21 to a40953e Compare May 5, 2020 15:41
RussKie
RussKie previously approved these changes May 7, 2020
View reviewed changes
@RussKie RussKie added the test-enhancement Improvements of test source code label May 7, 2020
@RussKie
Copy link
Member

RussKie commented May 7, 2020

MC

@hughbe hughbe force-pushed the Cleanup-DataGridViewRow-Tests branch from a40953e to 9a2b1a2 Compare May 7, 2020 08:14
@hughbe
Copy link
Contributor Author

hughbe commented May 7, 2020

Fixed the MC

@hughbe hughbe force-pushed the Cleanup-DataGridViewRow-Tests branch from 9a2b1a2 to 75bb408 Compare May 7, 2020 08:41
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #3213 into master will decrease coverage by 65.51821%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #3213          +/-   ##
====================================================
- Coverage   98.54350%   33.02529%   -65.51821%     
====================================================
  Files            420         866         +446     
  Lines         197872      254075       +56203     
  Branches        2756       36750       +33994     
====================================================
- Hits          194990       83909      -111081     
- Misses          2329      165354      +163025     
- Partials         553        4812        +4259
Flag Coverage Δ
#Debug 33.02529% <ø> (-65.51821%) ⬇️
#production 33.02529% <ø> (?)
#test ?

@RussKie
Copy link
Member

RussKie commented May 8, 2020 •
edited
Loading

I sadly have these things called finals to be revising for in the next few hours :((

This gives me some hope to go through the piles of GitHub notifications before you're back 🤣

@RussKie RussKie merged commit 6eadd11 into dotnet:master May 8, 2020
@ghost ghost added this to the 5.0 Preview5 milestone May 8, 2020
@hughbe hughbe deleted the Cleanup-DataGridViewRow-Tests branch May 8, 2020 08:48
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@hughbe hughbe

Labels
test-enhancement Improvements of test source code
Projects
None yet
Milestone
5.0 Preview5
Development

Successfully merging this pull request may close these issues.
2 participants
@hughbe @RussKie