Use generic Marshal.StructureToPtr #6044
Conversation
ghost
added
the
ghost
requested review from
| @@ -38,7 +38,8 @@ override protected bool ReleaseHandle() | |||
| } | |||
|
|
|||
| // uiaCondition is one of the Uia condition structs - eg UiaCoreApi.UiaAndOrCondition | |||
| internal static SafeConditionMemoryHandle AllocateConditionHandle(object uiaCondition) | |||
| internal static SafeConditionMemoryHandle AllocateConditionHandle<T>(T uiaCondition) | |||
There was a problem hiding this comment.
Using generics here allows to call the generic version of Marshal.StructureToPtr and also to avoid boxing of uiaCondition. Every call to AllocateConditionHandle passes a struct for uiaCondition.
|
Thank you! |
ThomasGoulet73
force-pushed
the
generic-structuretoptr
branch
from
caff652
to
f627e90
Compare
|
Hey all, any comment on this PR from the repo / code owners would be appreciated. The PR has been open for two months and it looks like a minor change that is not breaking anything. CC @SamBent / @fabiant3 / @vishalmsft / @singhashish-wpf Context: .NET Core 3.1 is EoL at the end of the year. Trimming is unstable and practically unusable in production with any subsequent .NET versions. There has been little to no progress on #3811 with duplicates being closed with no comment regarding the original issue. |
Description
Use generic Marshal.StructureToPtr instead of the non-generic. I removed the customs UnsafeNativeMethods.StructureToPtr which justs forwards to Marshal.StructureToPtr because it causes linker warnings because Marshal.StructureToPtr is annotated while UnsafeNativeMethods.StructureToPtr isn't.
Almost every call to Marshal.StructureToPtr were already using the generic overload without the need to change the code.
Contributes to #3811
Customer Impact
None, same behavior as the non-generic.
Regression
No
Testing
I manually tested a few of the generic and non-generic and they gave the same result.
Risk
None, same behavior as the non-generic.