Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Indeterminate animation when hiding ProgressBar #6266

Merged
merged 1 commit into from
May 9, 2022

Conversation

ThomasGoulet73
Copy link
Contributor

Fixes #6264

Description

Disable Indeterminate animation when hiding ProgressBar. Fixes a performance regression introduced in Aero2 theme (Windows 8 or newer)

Customer Impact

Better performance when hiding an indeterminate progress bar with the theme Aero2.

Regression

Performance regression introduced in Aero2 theme (Windows 8 or newer).

Testing

Tested with the sample in #6264 and a combination of Visibility and Indeterminate to validate that this PR does not break existing behavior.

Risk

Low.

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner March 17, 2022 03:20
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Mar 17, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent March 17, 2022 03:20
@ghost ghost added the Community Contribution A label for all community Contributions label Mar 17, 2022
@dipeshmsft dipeshmsft self-assigned this Mar 17, 2022
@ghost ghost assigned ThomasGoulet73 Apr 8, 2022
@dipeshmsft dipeshmsft merged commit 6bce6e2 into dotnet:main May 9, 2022
@ThomasGoulet73 ThomasGoulet73 deleted the fix-issue-6264 branch May 9, 2022 19:30
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WPF ProgressBars with IsIndeterminate = true appear to leak animations, since .NET 4.5
2 participants