Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sorcery for getting consistent names in the traces #6656

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Remove sorcery for getting consistent names in the traces #6656

merged 1 commit into from
Jul 4, 2022

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Jun 7, 2022 •
edited by ghost
Loading

That helps for trimming #3811

Microsoft Reviewers: Open in CodeFlow

@kant2002 kant2002 requested a review from a team as a code owner June 7, 2022 05:17
@ghost ghost assigned kant2002 Jun 7, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 7, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent June 7, 2022 05:17
@ghost ghost added the Community Contribution A label for all community Contributions label Jun 7, 2022
@kant2002
Copy link
Contributor Author

kant2002 commented Jun 7, 2022

For any reviewer, that traces can be enabled only from code, since TraceSwitch are not read from app.config at all in .NET.

@ThomasGoulet73
Copy link
Contributor

It's also worth noting that this class is only used when PresentationCore is built in Debug:

wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/MediaTrace.cs

Line 14 in 3817689

#if DEBUG

The class is also internal so Assembly.GetCallingAssembly() will always return PresentationCore.dll.

@dipeshmsft dipeshmsft self-assigned this Jun 20, 2022
@dipeshmsft
Copy link
Member

@kant2002, this PR has been included in the current test pass. Will share the results once the test pass is complete.

@dipeshmsft dipeshmsft merged commit fbccdb2 into dotnet:main Jul 4, 2022
@kant2002 kant2002 deleted the patch-7 branch July 4, 2022 12:21
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@kant2002 kant2002

@dipeshmsft dipeshmsft

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kant2002 @ThomasGoulet73 @dipeshmsft