Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GetXmlNamespaceMaps and SetXmlNamespaceMaps exception #8510

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

anjali-wpf
Copy link
Member

@anjali-wpf anjali-wpf commented Dec 6, 2023

Fixes #1583

Description

XmlAttributeProperties.GetXmlNamespaceMaps and XmlAttributeProperties.SetXmlNamespaceMaps were throwing System.InvalidCastException, as it was not able to cast object of type System.Collections.Hashtable to type System.String.

Tests updated : Test PR
Documentation updated : Documentation PR

Regression

NA

Testing

Tests have been modified to work correctly.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@anjali-wpf anjali-wpf requested a review from a team as a code owner December 6, 2023 16:48
@ghost ghost assigned anjali-wpf Dec 6, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 6, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf December 6, 2023 16:48
@rchauhan18 rchauhan18 merged commit d66b9b8 into main Feb 2, 2024
9 checks passed
@rchauhan18 rchauhan18 deleted the GetXmlNamespaceMapsChanges branch February 2, 2024 06:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XmlAttributeProperties.GetXmlNamespaceMaps throws System.InvalidCastException
4 participants