Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Themes folder with Generic.xaml under net5.0 and net6.0 folders. #8868

Merged

Conversation

himgoyalmicro
Copy link
Contributor

@himgoyalmicro himgoyalmicro commented Mar 5, 2024

Fixes #8773

Description

Added Themes folder with Generic.xaml under net5.0 and net6.0 folders so that when a user creates a WPF Custom Control Library project (NOT the .NET Framework version) it will include a Themes folder that in turn will contain Generic.xaml.

Testing

I created a new WPF Custom Control Library project (NOT the .NET Framework version) and it has a Themes folder that in turn contains Generic.xaml.

Microsoft Reviewers: Open in CodeFlow

@himgoyalmicro himgoyalmicro requested a review from a team as a code owner March 5, 2024 08:47
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 5, 2024
@dipeshmsft dipeshmsft marked this pull request as draft March 5, 2024 08:53
@rchauhan18 rchauhan18 removed the Community Contribution A label for all community Contributions label Mar 18, 2024
@himgoyalmicro himgoyalmicro marked this pull request as ready for review May 31, 2024 05:56
Copy link
Member

@anjali-wpf anjali-wpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dipeshmsft dipeshmsft merged commit 14dcf7f into dotnet:main Jul 30, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New WPF Custom Control Library projects are missing Themes folder and Generic.xaml file
4 participants