Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some attributes NRT annotations #8924

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Mar 18, 2024

Addresses #8905.

I haven't had time to review #8675 yet

Microsoft Reviewers: Open in CodeFlow

@halgab halgab requested a review from a team as a code owner March 18, 2024 22:39
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 18, 2024
@Kuldeep-MS
Copy link
Member

cc @dotMorten

Copy link
Member

@anjali-wpf anjali-wpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anjali-wpf anjali-wpf merged commit 6d26b95 into dotnet:main Jun 24, 2024
8 checks passed
@anjali-wpf
Copy link
Member

@halgab Thanks for your contribution.

@halgab halgab deleted the null-attributes-fixes branch June 24, 2024 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants