use getsockopt to check connection state after poll indicate writable #93

MOON-CLJ · 2019-01-26T05:23:21Z

No description provided.

mckelvin · 2019-01-30T14:51:55Z

Could you add more details on why we need this? It'd would best if you could add a test case or a piece of POC code to reproduce the issue you want to fix.

MOON-CLJ · 2019-01-31T03:12:44Z

@mckelvin this pr contains two points，

1，as suggestion by https://man.openbsd.org/connect.2 ，also see the https://man.openbsd.org/connect.2#EXAMPLES 。 add getsockopt with option SO_ERROR after poll indicate ok to double check after connect。it's not easy to add a test。
2，again，add more log with connection's pointer address to expose connection's state。

tclh123 · 2019-01-31T07:56:53Z

src/Connection.cpp

@@ -134,23 +135,44 @@ int Connection::connectPoll(int fd, struct addrinfo* ai_ptr) {
        pollfd_t pollfds[n_fds];
        pollfds[0].fd = fd;
        pollfds[0].events = POLLOUT;
+        // clean errno
+        errno = 0;


not necessary?

@tclh123 https://github.com/douban/libmc/blob/master/include/Common.h#L61 log will use errno，if not clean here。such as EINPROGRESS EALREADY above will show in the log，it's noisy。

MOON-CLJ changed the title ~~use getsockopt to check connection state after poll indicate writable~~ use getsockopt to check connection state after poll indicate writable[WIP] Jan 26, 2019

use getsockopt to check connection state after poll indicate writable

1e20ee9

MOON-CLJ changed the title ~~use getsockopt to check connection state after poll indicate writable[WIP]~~ use getsockopt to check connection state after poll indicate writable Jan 27, 2019

MOON-CLJ requested review from mckelvin and tclh123 January 30, 2019 09:39

tclh123 reviewed Jan 31, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use getsockopt to check connection state after poll indicate writable #93

use getsockopt to check connection state after poll indicate writable #93

MOON-CLJ commented Jan 26, 2019

mckelvin commented Jan 30, 2019

MOON-CLJ commented Jan 31, 2019 •

edited

Loading

tclh123 Jan 31, 2019

MOON-CLJ Jan 31, 2019

use getsockopt to check connection state after poll indicate writable #93

Are you sure you want to change the base?

use getsockopt to check connection state after poll indicate writable #93

Conversation

MOON-CLJ commented Jan 26, 2019

mckelvin commented Jan 30, 2019

MOON-CLJ commented Jan 31, 2019 • edited Loading

tclh123 Jan 31, 2019

Choose a reason for hiding this comment

MOON-CLJ Jan 31, 2019

Choose a reason for hiding this comment

MOON-CLJ commented Jan 31, 2019 •

edited

Loading