Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hitting https sites. #1

Merged
merged 2 commits into from
Dec 21, 2014
Merged

Support hitting https sites. #1

merged 2 commits into from
Dec 21, 2014

Conversation

jimkang
Copy link
Contributor

@jimkang jimkang commented Oct 1, 2014

This PR contains two changes so that node-ab can be used to hit sites that use https:

  1. Use the https module instead of the http module if the URL passed in uses the https: protocol.
  2. Accept self-signed certificates from the site.

@bcherny
Copy link

bcherny commented Dec 11, 2014

+1

doubaokun added a commit that referenced this pull request Dec 21, 2014
@doubaokun
Merge pull request #1 from jimkang/master
327927b 
Support hitting https sites.
@doubaokun doubaokun merged commit 327927b into doubaokun:master Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimkang @bcherny @doubaokun