Extend API with callback to signal events #4
Conversation
* DokiContentView::loadContent can be provided with a callback to handle start, load and failure events * DokiApi no longer exposed * DokiApi expects callback in getManufacturer method, making it stateless * Made some properties internal or private to lock unintended use * Updated dependencies
* Also added missing styles to be overridden
|
Thank you for contributing! It's a little difficult to tell what's been changed in the diff with all the formatting changes & stuff mixed in there, but I'll merge it into another branch for now and take the time to review it a little more thoroughly before the next release (hopefully adding a couple more things in the process). Anyone should be able to depend on |
|
Thank you for the quick merge! When do you plan the next release? |
|
@bearlysophisticated No idea! I'm hoping to have some time to work on this before next year, clean up my previous work a bit, add better documentation, and fix a couple problems from user feedback. I was hoping to get #3 in the next version too, but I'm not sure if that'll be possible. Err, that's not a very clear estimate is it. Let's say... next few weeks. lol |
Issue: The caller of the
DokiContentViewAPI is not aware of any error while loading content.Resolution:
DokiContentView::loadContent()can receive a callback object (DokiContentCallback) to whichDokiApiCallbackevents are translated. This allows the caller to be notified about events regarding content loading. In the future the library should use these events to handle errors and display them on the UI inDokiActivity.