Feature/geojson #38
Merged
Feature/geojson #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GPX::Geojson module for a simple conversion of GeoJSON features to GPX. Currently only supports LineString, Point, MultiLineString, and MultiPoint GeoJSON features. Note that the mapping of GeoJSON features to GPX features is not a clear 1-to-1 conversion, e.g., a GeoJSON LineString could map to either a GPX track or a GPX route. This implementation takes an opinionated strategy and maps each LineString as a segment of a GPX track. A MultiLineString maps to a GPX track, with each sub- MultiLineString being a GPX segment. Points and MultiPoints are converted to GPX waypoints.
- Address reduce and compact! feedback
|
Hey @andrewhao, FYI this PR replaces #21 addressing the feedback there. Would love a review and merge. Happy to help push this over the goal line. Huge thanks to @niborg for all the hard work. |
|
@dougfales, @andrewhao, Would it be possible to get this reviewed and merged? This PR expands the feature set, and also addresses the rubocop violations. I'd be happy to help maintain this gem as well, if you'd like to add me as a contributor. Thanks! |
|
Hi @tyrauber (and 👋 @niborg - long time!) I have to first apologize for dropping the ball on #21. That really should have been approved. As for contributor access, I'm open to it, but that needs to be granted by @dougfales. Maybe we can follow up that conversation in a separate issue? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #21, by rebasing the branch off master, addressing the rubocop offenses and feedback.