Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for --disallow-code-generation-from-strings #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidje13
Copy link

Alternative testing approach based on discussion in #41

This introduces a failing test for Node 9+. This is separate from the fix so that it can be combined with any of the existing PRs.

I have tested the test with the code from #42 and it passes, as expected.

@davidje13
Copy link
Author

davidje13 commented Mar 29, 2021

@dougwilson I took the approach you suggested. This certainly simplifies things and means it can still support Node 0.8 (no need for the cross-env package).

As noted in the description, this is an isolated test change so that it can be combined with any of the 3 PRs which offer fixes (#26 / #33 / #42), or another approach.


btw, since Node 5.12 is consistently failing in Travis but not Appveyor, I'd suggest it's probably a bad cache. Are you able to clear the Travis cache for 5.12? The only other option I can think of is that browserify has somehow broken on Node 5.12 but only on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant