Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Models #7

Closed
douweschulte opened this issue Dec 30, 2020 · 2 comments
Closed

Handle Models #7

douweschulte opened this issue Dec 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@douweschulte
Copy link
Owner

If I open and save pTLS-6484.pdb (an ensemble crystallographic pdb file) it crashes Chimera, but the original file does not. So clearly there is something different in the output. Also it would be cool to know what has to be enforced in terms of Atom list equality between the models, right now it enforces that every model has the exact same Atoms (except different position etc) which is not true for the mentioned PDB file.

@douweschulte douweschulte added the bug Something isn't working label Dec 30, 2020
@douweschulte
Copy link
Owner Author

As of now Chimera and PyMol can both open the ensemble file, so I guess it was linked to #38. But the question remains how strict to be on validating of models, so do HETATMs also need to correspond to each other

@douweschulte
Copy link
Owner Author

Based on the file format definition (v3.30) also the HETATMs should correspond, but I have seen examples where this is not the case. So I would propose to issue a LooseWarning when finding HETATMs that do not correspond.

This record is used only when more than one model appears in an entry. Generally, it is
employed mainly for NMR structures. The chemical connectivity should be the same for each
model. ATOM, HETATM, ANISOU, and TER records for each model structure and are
interspersed as needed between MODEL and ENDMDL records.

douweschulte added a commit that referenced this issue Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant