Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc support tls #291

Merged
merged 3 commits into from
Feb 23, 2022
Merged

feat: grpc support tls #291

merged 3 commits into from
Feb 23, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 17, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

if config.EnableTLS {
cert, err := tls.LoadX509KeyPair(config.CertFile, config.PrivateFile)
if err != nil {
panic(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem better to use xlog.Panicf instead, or return err directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #291 (76c6feb) into master (312afff) will decrease coverage by 0.07%.
The diff coverage is 4.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   23.33%   23.25%   -0.08%     
==========================================
  Files          83       83              
  Lines        5177     5199      +22     
==========================================
+ Hits         1208     1209       +1     
- Misses       3895     3915      +20     
- Partials       74       75       +1     
Impacted Files Coverage Δ
pkg/server/xgrpc/server.go 54.54% <0.00%> (-20.46%) ⬇️
pkg/server/xgrpc/config.go 26.86% <100.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312afff...76c6feb. Read the comment docs.

@sysulq sysulq merged commit 7a5c5d9 into master Feb 23, 2022
@sysulq sysulq deleted the feat/grpc-tls branch August 24, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants