Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support resty client #306

Merged
merged 6 commits into from
Mar 23, 2022
Merged

feat: support resty client #306

merged 6 commits into from
Mar 23, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Mar 22, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #306 (88ec489) into master (cd4839b) will increase coverage by 2.23%.
The diff coverage is 89.42%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   29.50%   31.74%   +2.23%     
==========================================
  Files          93       93              
  Lines        6463     6528      +65     
==========================================
+ Hits         1907     2072     +165     
+ Misses       4425     4321     -104     
- Partials      131      135       +4     
Impacted Files Coverage Δ
pkg/client/resty/resty.go 89.42% <89.42%> (ø)
pkg/client/rocketmq/init.go 1.78% <0.00%> (-0.11%) ⬇️
pkg/client/rocketmq/option.go 71.08% <0.00%> (ø)
pkg/xlog/trace.go
pkg/xlog/buffer_syncer.go
pkg/xlog/context.go 56.52% <0.00%> (ø)
pkg/client/rocketmq/interceptor.go 45.26% <0.00%> (+4.17%) ⬆️
pkg/client/rocketmq/consumer.go 62.29% <0.00%> (+4.88%) ⬆️
pkg/xlog/log.go 56.86% <0.00%> (+29.54%) ⬆️
pkg/xlog/api.go 47.05% <0.00%> (+43.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4839b...88ec489. Read the comment docs.

@sysulq sysulq merged commit a508e93 into master Mar 23, 2022
@sysulq sysulq deleted the feat/resty branch August 24, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants