-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update go mod version to go1.16 #328
Conversation
fix #327 |
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 32.86% 32.86%
=======================================
Files 97 97
Lines 6713 6713
=======================================
Hits 2206 2206
Misses 4373 4373
Partials 134 134 Continue to review full report at Codecov.
|
@ywanbing 从之前的CI情况来看,应该最低支持go1.15版本呀 |
确实欠考虑了,是 prometheus 内部需要 go1.17 |
@ywanbing 试试go1.15呢 ;-) |
如果15 可以过,那就是说明我们的测试用例可能不全面 |
。。。一不小心给 close了 😂 尴尬 |
@ywanbing Github Action是有跑1.15.x版本的测试,也是跑了go mod tidy的呀 |
我们还是先升级到1.15,后续如果1.15.x的单侧不通过了,再考虑升级上来,这样可能会更合适,你觉得呢?;-) |
如果1.15.x 是可以跑过了法,应该是在测试案例中没有引用到 go 高版本的东西,但是在用户项目中就说不定了。 |
ok, 那先用1.16 |
* fix:douyu#327 go mod version * 更新go.mod到go1.16
Describe what this PR does / why we need it
在使用当前项目的
go.mod
规定的最小go版本,不能正确处理依赖相关的库。Does this pull request fix one issue?
这个 pr 已经修复上述问题
Describe how you did it
修改 go.mod 最低支持的版本为 go1.16
Describe how to verify it
执行
go mod tidy
Special notes for reviews