Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go mod version to go1.16 #328

Merged
merged 2 commits into from
May 13, 2022
Merged

fix: update go mod version to go1.16 #328

merged 2 commits into from
May 13, 2022

Conversation

ywanbing
Copy link
Contributor

@ywanbing ywanbing commented May 13, 2022

Describe what this PR does / why we need it

在使用当前项目的 go.mod 规定的最小go版本,不能正确处理依赖相关的库。

Does this pull request fix one issue?

这个 pr 已经修复上述问题

Describe how you did it

修改 go.mod 最低支持的版本为 go1.16

Describe how to verify it

执行 go mod tidy

Special notes for reviews

@sysulq sysulq changed the title fix:#327 go mod version fix: update go mod version to go1.17 May 13, 2022
@sysulq
Copy link
Member

sysulq commented May 13, 2022

fix #327

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #328 (f4b90f9) into master (27bdbd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   32.86%   32.86%           
=======================================
  Files          97       97           
  Lines        6713     6713           
=======================================
  Hits         2206     2206           
  Misses       4373     4373           
  Partials      134      134           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bdbd2...f4b90f9. Read the comment docs.

@sysulq
Copy link
Member

sysulq commented May 13, 2022

@ywanbing 从之前的CI情况来看,应该最低支持go1.15版本呀

@ywanbing
Copy link
Contributor Author

@ywanbing从之前的CI情况来看,应该最低支持go1.15呀

确实欠考虑了,是 prometheus 内部需要 go1.17
但是当前项目的最低应该是 go1,16
原因在于:runtime\metrics 包在1.16 中增加

@ywanbing ywanbing changed the title fix: update go mod version to go1.17 fix: update go mod version to go1.16 May 13, 2022
@sysulq
Copy link
Member

sysulq commented May 13, 2022

@ywanbing 试试go1.15呢 ;-)

@ywanbing
Copy link
Contributor Author

@ywanbing 试试go1.15呢 ;-)

如果15 可以过,那就是说明我们的测试用例可能不全面

@ywanbing ywanbing closed this May 13, 2022
@ywanbing
Copy link
Contributor Author

。。。一不小心给 close了 😂 尴尬

@ywanbing ywanbing reopened this May 13, 2022
@sysulq
Copy link
Member

sysulq commented May 13, 2022

@ywanbing Github Action是有跑1.15.x版本的测试,也是跑了go mod tidy的呀
我刚在本地用go1.15.15版本测试了下,是可以的

@sysulq
Copy link
Member

sysulq commented May 13, 2022

我们还是先升级到1.15,后续如果1.15.x的单侧不通过了,再考虑升级上来,这样可能会更合适,你觉得呢?;-)

@ywanbing
Copy link
Contributor Author

ywanbing commented May 13, 2022

@ywanbing Github Action是有跑1.15.x版本的测试,也是跑了go mod tidy的呀 我刚在本地用go1.15.15版本测试了下,是可以的

如果1.15.x 是可以跑过了法,应该是在测试案例中没有引用到 go 高版本的东西,但是在用户项目中就说不定了。
我可以再观察一下项目的引用情况,在测试一下1.15.x 的版本。可好?

@sysulq
Copy link
Member

sysulq commented May 13, 2022

ok, 那先用1.16

@sysulq sysulq merged commit 5c32bdf into douyu:master May 13, 2022
hjxp pushed a commit to hjxp/jupiter that referenced this pull request May 24, 2022
* fix:douyu#327 go mod version

* 更新go.mod到go1.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants