feat: add cache and clean features #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 33.51% 33.56% +0.04%
==========================================
Files 92 92
Lines 6516 6516
==========================================
+ Hits 2184 2187 +3
+ Misses 4199 4197 -2
+ Partials 133 132 -1
Continue to review full report at Codecov.
|
sysulq
requested changes
May 18, 2022
| panic(err) | ||
| } | ||
| } else if err != nil && !os.IsExist(err) { | ||
| // 这里的错误，是说明出现了未知的错误，应该抛出 | ||
| panic(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
如果已经存在，也尝试拉取模板，这缓存不就没有意义了吗？
There was a problem hiding this comment.
不然模板会一直不更新呀，可以考虑根据文件变更时间决定，比如超过1天就更新下，pull增量的部分比全量pull还是会快很多
There was a problem hiding this comment.
另一个思路是，让用户确认是否更新模板，可以参考oh-my-zsh的玩法 :-)
sysulq
changed the title
sysulq
approved these changes
May 19, 2022
hjxp
pushed a commit
to hjxp/jupiter
that referenced
this pull request
May 24, 2022
* feat#336 add cache and clean features * compatible with windows and Unix * perfect the content * add one todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews