Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): add auto upgrade(#341) #345

Merged
merged 3 commits into from
Jul 22, 2022
Merged

feat(cmd): add auto upgrade(#341) #345

merged 3 commits into from
Jul 22, 2022

Conversation

ywanbing
Copy link
Contributor

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #345 (7e15856) into master (cefc753) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   33.56%   33.93%   +0.37%     
==========================================
  Files          92       88       -4     
  Lines        6516     6441      -75     
==========================================
- Hits         2187     2186       -1     
+ Misses       4197     4125      -72     
+ Partials      132      130       -2     
Impacted Files Coverage Δ
pkg/store/gorm/init.go 30.76% <0.00%> (-11.54%) ⬇️
pkg/client/rocketmq/interceptor.go 56.17% <0.00%> (-1.33%) ⬇️
pkg/client/rocketmq/consumer.go 40.30% <0.00%> (-0.63%) ⬇️
pkg/server/xgrpc/interceptor.go 1.07% <0.00%> (-0.14%) ⬇️
pkg/client/rocketmq/option.go 71.08% <0.00%> (ø)
pkg/store/gorm/interceptor.go 0.00% <0.00%> (ø)
pkg/client/grpc/interceptor.go 0.00% <0.00%> (ø)
pkg/trace/carrier.go
pkg/trace/trace.go
pkg/trace/init.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefc753...7e15856. Read the comment docs.

@sysulq
Copy link
Member

sysulq commented May 26, 2022

目前这个方案每次都需要请求github,是不是可以考虑基于修改时间来做提示,让用户自己选择是否更新模板呢

如下
截屏2022-05-26 10 53 28

@ywanbing
Copy link
Contributor Author

ywanbing commented May 26, 2022

目前这个方案每次都需要请求github,是不是可以考虑基于修改时间来做提示,让用户自己选择是否更新模板呢

如下 截屏2022-05-26 10 53 28

如果通过修改时间来判断,还是会去拉取github的信息来判断是否有内容更新,所以效果其实都是一样的。
对于让用户手动确认更新,倒是不错的选择。

加上修改时间来判断,好像是每天的第一次才会去检查是否需要更新。后面每次运行一直都不会存在 github 的请求,因为今天已经检查过更新了。

@sysulq
Copy link
Member

sysulq commented May 26, 2022

目前这个方案每次都需要请求github,是不是可以考虑基于修改时间来做提示,让用户自己选择是否更新模板呢
如下 截屏2022-05-26 10 53 28

如果通过修改时间来判断,还是会去拉取github的信息来判断是否有内容更新,所以效果其实都是一样的。 对于让用户手动确认更新,倒是不错的选择。

加上修改时间来判断,好像是每天的第一次才会去检查是否需要更新。后面每次运行一直都不会存在 github 的请求,因为今天已经检查过更新了。

嗯,是这个意思,尽量避免每次都要访问github。

cmd/jupiter/internal/cmd/cmd_new.go Outdated Show resolved Hide resolved
@sysulq sysulq changed the title add auto upgrade(#341) feat(cmd): add auto upgrade(#341) Jun 9, 2022
@sysulq sysulq merged commit 0b643a7 into douyu:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants