Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support opentelemetry #346

Merged
merged 11 commits into from
Jun 8, 2022
Merged

feat: support opentelemetry #346

merged 11 commits into from
Jun 8, 2022

Conversation

hjxp
Copy link
Contributor

@hjxp hjxp commented May 23, 2022

support opentelemetry

@hjxp hjxp requested a review from sysulq May 23, 2022 09:19
@sysulq sysulq changed the title Feature/opentelemetry feat: support opentelemetry May 23, 2022
@sysulq
Copy link
Member

sysulq commented May 23, 2022

#339

sysulq
sysulq requested changes Jun 8, 2022
View reviewed changes
go.mod Outdated
@@ -63,18 +66,14 @@ require (

require (
github.com/aws/aws-sdk-go v1.40.45 // indirect
github.com/cosmtrek/air v0.0.0-20220504050646-0c5e73afb027
github.com/cosmtrek/air v1.29.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/cosmtrek/air 这里需要升级到v1.40.1

不然不支持args_bin参数

pkg/xtrace/utils.go Outdated
@@ -0,0 +1,60 @@
// Copyright 2020 Douyu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022

pkg/client/rocketmq/consumer.go Outdated
ctx, span = tracer.Start(ctx, msg.Topic, carrier, trace.WithAttributes(attrs...))
defer span.End()
span.SetAttributes(
semconv.MessagingDestinationKindKey.String(msg.Topic),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行代码可以和 semconv.MessagingSystemKey.String("rocketmq") 放在一起

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #346 (81addd7) into master (cefc753) will increase coverage by 0.37%.
The diff coverage is 30.13%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   33.56%   33.93%   +0.37%     
==========================================
  Files          92       88       -4     
  Lines        6516     6441      -75     
==========================================
- Hits         2187     2186       -1     
+ Misses       4197     4123      -74     
  Partials      132      132
Impacted Files Coverage Δ
pkg/client/grpc/interceptor.go 0.00% <0.00%> (ø)
pkg/client/rocketmq/option.go 71.08% <0.00%> (ø)
pkg/server/xgrpc/interceptor.go 1.07% <0.00%> (-0.14%) ⬇️
pkg/store/gorm/interceptor.go 0.00% <ø> (ø)
pkg/client/rocketmq/consumer.go 40.30% <31.57%> (-0.63%) ⬇️
pkg/client/rocketmq/interceptor.go 56.17% <62.50%> (-1.33%) ⬇️
pkg/client/resty/resty.go 89.90% <100.00%> (+0.48%) ⬆️
pkg/client/grpc/balancer/p2c/least_loaded.go 75.00% <0.00%> (-12.50%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefc753...81addd7. Read the comment docs.

@sysulq sysulq self-requested a review June 8, 2022 03:53
@sysulq sysulq merged commit c2a39be into douyu:master Jun 8, 2022
@sysulq sysulq mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysulq sysulq sysulq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjxp @sysulq @codecov-commenter