Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace xcast with cast #358

Merged
merged 2 commits into from
Jul 22, 2022
Merged

feat: replace xcast with cast #358

merged 2 commits into from
Jul 22, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Jul 22, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #358 (029a72d) into master (23ea45d) will increase coverage by 2.97%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   33.61%   36.58%   +2.97%     
==========================================
  Files          89       82       -7     
  Lines        6268     5256    -1012     
==========================================
- Hits         2107     1923     -184     
+ Misses       4034     3214     -820     
+ Partials      127      119       -8     
Impacted Files Coverage Δ
pkg/conf/conf.go 4.16% <ø> (+0.10%) ⬆️
pkg/store/gorm/config.go 0.00% <0.00%> (ø)
pkg/util/xmap/map.go 0.00% <ø> (ø)
pkg/util/xmap/util.go 43.54% <ø> (ø)
pkg/client/grpc/config.go 30.15% <100.00%> (ø)
pkg/client/redis/config.go 33.87% <100.00%> (ø)
pkg/client/resty/resty.go 90.00% <100.00%> (ø)
pkg/store/gorm/init.go 42.30% <0.00%> (+11.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sysulq sysulq merged commit d7a80a4 into master Jul 22, 2022
@sysulq sysulq deleted the feat/xcasst branch August 24, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants