Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json and yml config type #584

Merged
merged 4 commits into from
Nov 28, 2022
Merged

feat: support json and yml config type #584

merged 4 commits into from
Nov 28, 2022

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Nov 28, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #584 (496dcd9) into master (fcd2506) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   52.02%   52.01%   -0.01%     
==========================================
  Files         105      105              
  Lines        6964     6973       +9     
==========================================
+ Hits         3623     3627       +4     
- Misses       3075     3080       +5     
  Partials      266      266              
Impacted Files Coverage Δ
pkg/conf/init.go 2.63% <0.00%> (-0.82%) ⬇️
pkg/store/gorm/logger.go 37.50% <0.00%> (-14.59%) ⬇️
pkg/conf/conf.go 36.06% <0.00%> (+3.68%) ⬆️
pkg/conf/api.go 18.18% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit 661dcba into master Nov 28, 2022
@sysulq sysulq deleted the feat/config-type branch November 30, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants