Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rocketMq pull and poll #620

Merged
merged 13 commits into from
Dec 26, 2022
Merged

feat: support rocketMq pull and poll #620

merged 13 commits into from
Dec 26, 2022

Conversation

hjxp
Copy link
Contributor

@hjxp hjxp commented Dec 13, 2022

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@hjxp hjxp changed the title feature: support rocketMq pull and poll feat: support rocketMq pull and poll Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #620 (551c7e0) into master (08a6bed) will increase coverage by 0.65%.
The diff coverage is 63.82%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   52.69%   53.34%   +0.65%     
==========================================
  Files         189      190       +1     
  Lines       10027    10092      +65     
==========================================
+ Hits         5284     5384     +100     
+ Misses       4361     4315      -46     
- Partials      382      393      +11     
Impacted Files Coverage Δ
pkg/client/rocketmq/producer.go 52.38% <ø> (+6.99%) ⬆️
pkg/client/rocketmq/push_consumer.go 48.02% <53.33%> (ø)
pkg/client/rocketmq/pull_consumer.go 56.83% <56.83%> (ø)
pkg/client/rocketmq/interceptor.go 62.81% <66.66%> (+2.91%) ⬆️
pkg/client/rocketmq/option.go 75.25% <83.01%> (+2.22%) ⬆️
pkg/conf/conf.go 45.30% <100.00%> (+0.22%) ⬆️
pkg/registry/etcdv3/registry.go 72.26% <0.00%> (+1.02%) ⬆️
pkg/client/redis/client.go 74.74% <0.00%> (+3.03%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hjxp hjxp temporarily deployed to tablestore-live December 13, 2022 13:30 — with GitHub Actions Inactive
@hjxp hjxp temporarily deployed to tablestore-live December 15, 2022 13:02 — with GitHub Actions Inactive
@hjxp hjxp temporarily deployed to tablestore-live December 26, 2022 07:05 — with GitHub Actions Inactive
@hjxp hjxp merged commit b1b5c51 into master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants