tweaks to remove items from global scope #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2013 12:32
…intentionWrapper and not all javascript
ghost
pushed a commit
that referenced
this pull request
Mar 12, 2013
tweaks to remove items from global scope
ghost
merged commit
adamrights
pushed a commit
to adamrights/intentionjs
that referenced
this pull request
Sep 9, 2013
tweaks to remove items from global scope
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made 2 changes, one small (moved 'use strict' out of global scope) and one bigger ('intentionWrapper' became an anonymous function, removed from the global scope). If you don't like the changes, feel free to yell at me when you get back in the office.