Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUM_PROC_THREADS not being honored when processing input. #9234

Closed
ferdymercury opened this issue Mar 28, 2022 · 4 comments
Closed

NUM_PROC_THREADS not being honored when processing input. #9234

ferdymercury opened this issue Mar 28, 2022 · 4 comments
Labels
bug

Comments

@ferdymercury
Copy link
Contributor

ferdymercury commented Mar 28, 2022 •
edited
Loading

Describe the bug
In an 8-thread computer, I enable NUM_PROC_THREADS to 4 when building my documentation. However, in some steps, doxygen uses 8 even if I told him to only use 4. In other steps, it correctly respects the maximum.

Expected behavior
It always respects the maximum.

Screenshots
doxygen's output is very clear about this:

...
Processing input using 8 threads.
...
Generating code files using 4 threads.
...

To Reproduce
Just turn in any project NUM_PROC_THREADS to half of your max number of threads, and check the output.

Version
1.9.4 (91095fb62f0bc2c624b0e8e49d9316f51be76559*)
ferdymercury added a commit to ferdymercury/doxygen that referenced this issue Mar 28, 2022
@ferdymercury
https://github.com/doxygen/doxygen/issues/9234
317bf37 
Read num proc threads also for processing
@ferdymercury
Copy link
Contributor Author

I proposed a patch: #9235

albert-github added a commit to albert-github/doxygen that referenced this issue Mar 30, 2022
@albert-github
issue doxygen#9234 NUM_PROC_THREADS not being honored when processing…
9abc310 
… input

In the proposed pull request doxygen#9235 the correct solution was given for the specific place.
To overcome the problem to have to have the correction code at each place where `NUM_PROC_THREADS` is used the code is moved to a central place.
@albert-github
Copy link
Collaborator

I've just pushed a proposed patch, pull request #9237, which in my opinion supersedes the proposed pull request #9235

doxygen added a commit that referenced this issue Apr 1, 2022
@doxygen
Merge pull request #9237 from albert-github/feature/issue_9234
89a9b2c 
issue #9234 NUM_PROC_THREADS not being honored when processing input
@albert-github albert-github added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Apr 1, 2022
@albert-github
Copy link
Collaborator

Code has been integrated in master on GitHub (please don't close the issue as this will be done at the moment of an official release).

@doxygen
Copy link
Owner

doxygen commented May 5, 2022

This issue was previously marked 'fixed but not released',
which means it should be fixed in doxygen version 1.9.4.
Please verify if this is indeed the case. Reopen the
issue if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label May 5, 2022
@doxygen doxygen closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doxygen @albert-github @ferdymercury