Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure dot graph, nodes and arrows attributes #9463

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

makelinux
Copy link
Contributor

Configure dot graph, nodes and arrows attributes

For example, default:
DOT_NODE_ATTR = shape=box
┌────────┐     ┌────────┐
│ caller │────►│ callee │
└────────┘     └────────┘

new options:
DOT_NODE_ATTR = shape=plain

    caller────►callee

DOT_NODE_ATTR = shape=plaintext

   caller  ────►  callee

Features of only nodes without boxes:
- a root node is in bold font
- truncated nodes are in italic

Changes and features:
- writeBox renamed to generic writeNode and reworked
- arrows and nodes can be configured
- DOT_FONTNAME, DOT_FONTSIZE are replaced with DOT_GRAPH_ATTR,
DOT_COMMON_ATTR, DOT_EDGE_ATTR, DOT_NODE_ATTR
- removed duplicated code and used DotGraph::writeGraphHeader

Before:
image

With
DOT_NODE_ATTR = shape=plaintext height=0.2 width=0.4 :
graph_legend

src/dotdirdeps.cpp Outdated Show resolved Hide resolved
@@ -0,0 +1,9 @@
# Usage:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed for something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is manual test for new code in function Config::updateObsolete. It is not connected to test suite. It could be connected latter.

@doxygen
Copy link
Owner

doxygen commented Jul 25, 2022

@makelinux If you can look at the merge conflict and the remark I put at the testing/obsolete file, then it looks good to be merged.

For example, default:
DOT_NODE_ATTR = shape=box
┌────────┐     ┌────────┐
│ caller │────►│ callee │
└────────┘     └────────┘

new options:
DOT_NODE_ATTR = shape=plain

    caller────►callee

DOT_NODE_ATTR = shape=plaintext

   caller  ────►  callee

Features of only nodes without boxes:
- a root node is in bold font
- truncated nodes are in italic

Changes and features:
- writeNode is splitted from writeBox
- arrows and nodes can be configured
- new more generic options DOT_COMMON_ATTR,
  DOT_EDGE_ATTR, DOT_NODE_ATTR
  obsolete DOT_FONTNAME and DOT_FONTSIZE.
- removed duplicated code and used DotGraph::writeGraphHeader
@doxygen doxygen merged commit 884a574 into doxygen:master Jul 30, 2022
@albert-github albert-github added enhancement a request to enhance doxygen, not a bug fixed but not released Bug is fixed in github, but still needs to make its way to an official release labels Jul 30, 2022
@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a request to enhance doxygen, not a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants