Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Sub::Name, perl 5.010 to test recommendations #18

Closed

Conversation

karenetheridge
Copy link

no other metadata or prereqs have changed (verified with 'dzil build --not' and a recursive diff against the last uploaded release)

@@ -1,9 +1,7 @@
package Try::Tiny;
use 5.006;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you removed this use statement?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Fri, Apr 25, 2014 at 06:03:02PM -0700, Jesse Luehrs wrote:

@@ -1,9 +1,7 @@
-package Try::Tiny;
-use 5.006;

Any reason you removed this use statement?

If it remains, [AutoPrereqs] will pick up on it, which will result in an extra { runtime => { recommends => { perl => '5.006' } } } that doesn't add any value.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it do that? It's already in the dist.ini as a hard dep, so I don't see why it should make a difference either way. If [Prereqs::Soften] can't handle having a 'requires' dep on one version of something and a 'recommends' dep on a higher version of that same thing, I think that it should be fixed, rather than removing potentially useful metadata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Fri, Apr 25, 2014 at 09:00:09PM -0700, Jesse Luehrs wrote:

@@ -1,9 +1,7 @@
-package Try::Tiny;
-use 5.006;

Why would it do that? It's already in the dist.ini as a hard dep, so I don't see why it should make a difference either way. If [Prereqs::Soften] can't handle having a 'requires' dep on one version of something and a 'recommends' dep on a higher version of that same thing, I think that it should be fixed, rather than removing potentially useful metadata.

It's not "it can't handle it" - but that it would be doing exactly what
it's told to do - change all 'perl' requires that it sees to 'recommends'.
When it runs, all there is is the 'test' entry, which is the one we want to
soften (5.010).

The plugin ordering matters - the 5.006 prereq is not added as a 'requires'
prereq until after [Prereqs::Soften] runs.

Try doing a build, move the build dir aside, do another build, and then a
diff -r to see the difference.

@doy doy closed this in 77f6c1e Apr 29, 2014
@karenetheridge karenetheridge deleted the topic/prereq_recommendations branch May 6, 2014 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants