-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using custom-config-file removes empty string objects in .plist #136
Comments
I'm not able to reproduce this behaviour (see console output below). This plugin uses the plist module to read and write the plist contents, so any issue in formatting the plist file is likely to be caused by that.
console output
|
I cannot replicate the issue with the above setup. Although I cannot see any other plugin changing the plist in my repo. |
Aha! I think I've found the cause of it. This issue originally cropped up in #90. The cause was a bug in In the meantime, the ownership of However, I don't think the problem encountered with this plugin is the indirect use of plist.js#79 is still open and it seems no more recent versions have been released which fix that issue, however there's an open PR to fix it. I'm thinking that if I directly reference the fork which contains the fix in the |
Hey @dpa99c thanks for the quick response. Are you going to push this into a release? |
@chrismowbray I've just published v5.0.1 of this plugin, which references the forked Give it a go in your project and let me know if it works OK. You may need to first remove |
@dpa99c im not seeing the 5.0.1 in https://github.com/dpa99c/cordova-custom-config/releases or npm. Maybe it takes a while |
Yep and now I see it! ill post back when I test it out |
@dpa99c All looks good now. Thanks for the quick response. This issue can be closed |
Running a standard config update:
This removes any empty string objects from the .plist.
This...
becomes this...
The .plist in now in an unreadable format and cant be used.
The text was updated successfully, but these errors were encountered: