-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from nwsapi 2.2.2 to 2.2.3 creates infinite loop #80
Comments
@cmdcolin |
Appears fixed after linking the latest master branch with my test environment! |
can probably close now |
note that 2.2.4 might not be on npm yet, though it appears tagged on master branch |
@cmdcolin do you have a plan on when you're going to release this fix? Also, should |
just to be clear, I am not in charge of the release process :) I believe that would be @dperini |
As another data point, this bug also affected our code when using If this had been released promptly, it would have saved us a lot of headaches 😄 |
A fixed 2.2.4 is on its way to npm in a few moments, the fix was not trivial it is a new attempt to solve different problems parsing edge cases related with the :not pseudo-class, I hope the wait was worth it. |
@cmdcolin |
@dperini yes, the now published v2.2.4 fixes it for me! thanks much :) |
@dperini Thanks for responding so promptly! v2.2.4 has fixed the issue for me as well. |
Not similar, but after upgrading to latest 2.2.6, JEST + RTL test cases started failing which were working just fine before sometime. Anyone else facing this issue? |
Hello there,
I found that upgrading nwsapi from 2.2.2 to 2.2.3 created an infinite loop in a repo that runs jest/jsdom/testing-library on a page that uses @mui/x-data-grid. I isolated this infinite loop to the nwsapi version bump.
Here is a screenshot of the code that gets infinite looped
code from screenshot pasted below here
I am not sure exactly how it generates this code, but it seems to me that it would be easy for this loop to never end (and indeed, it does not end in my code) as
e
never changes in this loop?I made a 'minimal' reproduction here https://github.com/cmdcolin/mui_datagrid_jest_infinite_loop/, it is a create-react-app instance
steps to repro
the only difference between these branches is the nwsapi version bump
If you think this is something to report to a different repository (e.g. jsdom or testing-library or something), let me know
The text was updated successfully, but these errors were encountered: