Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_return_routes fix #317

Merged
merged 2 commits into from
Jul 7, 2020
Merged

global_return_routes fix #317

merged 2 commits into from
Jul 7, 2020

Conversation

5andr0
Copy link
Contributor

@5andr0 5andr0 commented Jul 6, 2020

Hey @dperson, long time no see!
i started using your docker hub image and found out that my global return routes aren't working anymore.

ip -4 route | grep -q "$i\\>" || 
    ip route add default via $g table 10

the route on table 10 wasn't added because it falsely detected the default gateway route as a duplicate.
To check if the table 10 entries already exists you have to add show table 10 on the ip commands like in my fix here.

You also had a copy paste error. You referenced $i instead of $g in the for g in $gw loops.

This will fix #316 and all other remote port issues

Let me know when the fix is on docker hub

Cheers!

@dperson dperson self-assigned this Jul 7, 2020
@dperson dperson merged commit 513a56d into dperson:master Jul 7, 2020
dperson pushed a commit that referenced this pull request Jul 7, 2020
* global_return_routes fix

* global_return_routes var ref fix
@javierdlg
Copy link

javierdlg commented Nov 12, 2020

Looks like this recent merge keeps old routing preferences if they get changed through the docker compose yaml. See #342 for where I'm hitting this issue when I changed networks and changed the routing. The old entry gets pulled from somewhere but I can't tell where and it kills my vpn's network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access deluge on port 8112 through OpenVPN remotely
3 participants