refactor google analytics to use gtag #911
Conversation
lib/gtag.js
Outdated
| export const event = gaEvent => { | ||
| window.gtag("event", gaEvent.contributor, { | ||
| category: `${gaEvent.type} : ${gaEvent.partner}`, | ||
| label: `${gaEvent.itemId} : ${gaEvent.title}` |
There was a problem hiding this comment.
In the docs/examples you link to in the PR, the keys are event_category and event_label rather than category and label. I'm guessing this makes a difference?
There was a problem hiding this comment.
correct. changed (re-sanity check?). i notice you don't use the value and assume that's fine
There was a problem hiding this comment.
That is correct, I don't use the value field.
components/shared/ListView/index.js
Outdated
| const links = document.getElementsByClassName("internalItemLink"); | ||
| const items = this.props.items; | ||
|
|
||
| // alert(`${JSON.stringify(items[0].linkAs)} : ${JSON.stringify(links[0].href)}`); |
There was a problem hiding this comment.
I'm guessing this is leftover from some debugging task and can be deleted.
| window.dataLayer = window.dataLayer || []; | ||
| function gtag(){dataLayer.push(arguments);} | ||
| gtag('js', new Date()); | ||
| gtag('config', '${gaTrackingId}'); |
There was a problem hiding this comment.
I don't recall Document or MyDocument is used so just to sanity check, can you clarify when exactly this gtag('config', '${gaTrackingId}') pageview tracking event would be fired? Is it just when MainLayout is rendered?
There was a problem hiding this comment.
this is the wrapper of any/every page with or without MainLayout. this should instantiate gtag on any server-side page render. client-side calls would not re-instantiate.
per vercel/next.js#4036,
gtag.jsreplaces olderanalytics.jssolution and is currently recommended by Google - https://developers.google.com/analytics/devguides/collection/gtagjs/migrationthe previous solution relied on wrapper components that got in the way and were very redundant. those components were removed and the analytics were implemented as recommended in the nextjs
with-google-analyticsexample: https://github.com/zeit/next.js/tree/master/examples/with-google-analyticsthe
lib/googleAnalyticsfolder was also removed and replaced with alib/gtag.jsfile. addingalerts to that file should allow for testingfixes #907