chore: update rustfmt #8
Conversation
|
@thomaseizinger any ideas about how to get this working? 😅 I'm getting these same errors locally. |
Unfortunately no but there has been a toolchain bump a couple of days ago: rust-lang/rustfmt@9e1973f Maybe try a newer revision? |
Cargo.toml
Outdated
| rustfmt-nightly = { git = "https://github.com/rust-lang/rustfmt" } | ||
| serde = { version = "1.0.88", features = ["derive"] } | ||
| dprint-core = "0.49.1" | ||
| rustfmt-nightly = { git = "https://github.com/rust-lang/rustfmt", rev = "7913f13" } |
There was a problem hiding this comment.
Not sure if you know this but you can bump a git dependency that is tracked via the lockfile with:
cargo update -p rustfmt-nightlyThere was a problem hiding this comment.
What benefit does that bring? It seems better to have the revision stored here because it's like a version number and then the revision number won't be accidentally updated in Cargo.lock when running cargo update for the other dependencies. I'm probably missing something.
There was a problem hiding this comment.
I don't think there is a functional difference.
It gets confusing if you ever look at the lockfile yourself because it will have two revisions in the URL. The first one being the revision that latest HEAD was at the time you last updated.
The second one being the revision you actually want to checkout.
It is like a version number yes but even for crates.io dependencies, the version that is actually used is only in the lockfile. It probably comes down to personal preference really :)
…and update rustfmt again
Yup! Upgrading seems to have resolved the issue. Thanks! 😊 |
No description provided.