-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Musse #102
Musse #102
Conversation
unifold/config.py
Outdated
"crop": False, | ||
"crop_size": None, | ||
"crop": True, | ||
"crop_size": 384, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the changes of above two lines?
unifold/config.py
Outdated
@@ -160,6 +166,8 @@ def base_config(): | |||
], | |||
"use_templates": use_templates, | |||
"is_multimer": is_multimer, | |||
"is_single": is_single, | |||
"feature_src": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? should we keep it?
unifold/ssmultimer/__init__.py
Outdated
@@ -0,0 +1,2 @@ | |||
from . import model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename ssmultimer to musse?
unifold/ssmultimer/dataset.py
Outdated
# total_length = sum(x["aatype"].shape[0] for x in all_chain_features) | ||
# pair = dok_matrix( | ||
# (total_length, total_length, all_chain_features[0]["pair"].shape[-1]), | ||
# dtype=all_chain_features[0]["pair"].dtype, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is annotation clearing needed?
unifold/data/process.py
Outdated
@@ -48,10 +50,61 @@ def nonensembled_fns(common_cfg, mode_cfg): | |||
|
|||
operators.append(data_ops.make_atom14_masks) | |||
operators.append(data_ops.make_target_feat) | |||
if common_cfg.structure_refine: | |||
operators.append(data_ops.input_atom37_to_frames()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
unifold/config.py
Outdated
@@ -21,6 +21,7 @@ | |||
inf = mlc.FieldReference(3e4, field_type=float) | |||
use_templates = mlc.FieldReference(True, field_type=bool) | |||
is_multimer = mlc.FieldReference(False, field_type=bool) | |||
is_single = mlc.FieldReference(False, field_type=bool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename this to use_musse
unifold/config.py
Outdated
@@ -591,6 +607,23 @@ def multimer(c): | |||
recursive_set(c, "max_msa_clusters", 256) | |||
c.data.train.crop_size = 384 | |||
c.loss.violation.weight = 0.5 | |||
elif name == "single_multimer_3b_newemb": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
musse
unifold/inference.py
Outdated
sequence_ids = open(os.path.join(data_folder, "chains.txt")).readline().split() | ||
batch, _ = load_and_process( | ||
batch, _ = load_and_process_ss( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will harm normal unifold load_and_process. check if the two functions are equivalent, and use old fn name.
* Uni-Fold Musse * mv plm to ssmultimer * update readme * udpatereadme * ss to musse * rename fn * fix monomer bug
No description provided.