Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musse #102

Merged
merged 7 commits into from
Mar 2, 2023
Merged

Musse #102

merged 7 commits into from
Mar 2, 2023

Conversation

teslacool
Copy link
Contributor

No description provided.

"crop": False,
"crop_size": None,
"crop": True,
"crop_size": 384,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the changes of above two lines?

@@ -160,6 +166,8 @@ def base_config():
],
"use_templates": use_templates,
"is_multimer": is_multimer,
"is_single": is_single,
"feature_src": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this? should we keep it?

unifold/config.py Outdated Show resolved Hide resolved
unifold/config.py Outdated Show resolved Hide resolved
unifold/data/process.py Outdated Show resolved Hide resolved
unifold/inference.py Outdated Show resolved Hide resolved
unifold/inference.py Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
from . import model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename ssmultimer to musse?

# total_length = sum(x["aatype"].shape[0] for x in all_chain_features)
# pair = dok_matrix(
# (total_length, total_length, all_chain_features[0]["pair"].shape[-1]),
# dtype=all_chain_features[0]["pair"].dtype,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is annotation clearing needed?

unifold/data/process.py Show resolved Hide resolved
@@ -48,10 +50,61 @@ def nonensembled_fns(common_cfg, mode_cfg):

operators.append(data_ops.make_atom14_masks)
operators.append(data_ops.make_target_feat)
if common_cfg.structure_refine:
operators.append(data_ops.input_atom37_to_frames())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

unifold/msa/utils.py Show resolved Hide resolved
@@ -21,6 +21,7 @@
inf = mlc.FieldReference(3e4, field_type=float)
use_templates = mlc.FieldReference(True, field_type=bool)
is_multimer = mlc.FieldReference(False, field_type=bool)
is_single = mlc.FieldReference(False, field_type=bool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to use_musse

@@ -591,6 +607,23 @@ def multimer(c):
recursive_set(c, "max_msa_clusters", 256)
c.data.train.crop_size = 384
c.loss.violation.weight = 0.5
elif name == "single_multimer_3b_newemb":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

musse

sequence_ids = open(os.path.join(data_folder, "chains.txt")).readline().split()
batch, _ = load_and_process(
batch, _ = load_and_process_ss(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will harm normal unifold load_and_process. check if the two functions are equivalent, and use old fn name.

unifold/modules/alphafold.py Outdated Show resolved Hide resolved
unifold/modules/alphafold.py Show resolved Hide resolved
@guolinke guolinke merged commit 4f232f1 into dptech-corp:MuSSe Mar 2, 2023
jnooree pushed a commit to seoklab/Uni-Fold that referenced this pull request Apr 24, 2024
* Uni-Fold Musse

* mv plm to ssmultimer

* update readme

* udpatereadme

* ss to musse

* rename fn

* fix monomer bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants