Same token same color #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assigns token colour by ID rather than by position. This makes highlighting more consistent.
Before (note that the second "kindness" has a different colour from the first "kindness".):
After:
This colour assignment persists for the duration of the session (until the user closes or refreshes the page). The benefit of this is that a change to the beginning of the text doesn't throw off the colours in subsequent parts. The tradeoff is that token colours may change between sessions, which might seem confusing to users. But I think the more immediate in-session consistency is worth the loss of between-session consistency.
I also changed the break behaviour from
break-alltobreak-wordto stop confusing breaking of words/numbers across lines.