Bugfix: fail at getting uuid more gracefully #1702
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Apr 25, 2023
| @@ -77,8 +77,12 @@ const getCard = (cardCode) => { | |||
|
|
|||
| const getUuid = (cardCode) => { | |||
| const [setCode, cardNumber] = cardCode.split(":"); | |||
| const { cardsByNumber } = getSet(setCode.toUpperCase()); | |||
There was a problem hiding this comment.
this line here was the gotcha - destructuring undefined was causing an error to be thrown in CI
I don't know why the set would not be found, maybe that's an error which should throw, as it shows your data is somehow really wrong.
|
Node 18 failed - didn't download the data needed. Re-running to see if it passes |
|
WIP - closest I've got is that there is something going wrong in Node 18 CI around download of sets - it seems like malformed sets are being saved e.g. |
mixmix
changed the title
tooomm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was seeing CI fail on this particular line in another PR, this is an attempt to fix that