Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort packs by rarity by default #336

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Sort packs by rarity by default #336

merged 1 commit into from
Feb 20, 2019

Conversation

HerveH44
Copy link
Contributor

Closes #330

@tooomm
Copy link
Contributor

tooomm commented Feb 20, 2019

👍

But for RNA the gate comes right after the uncommon cards, not at the end.
You ordered special to the end, so there might be another issue.

@HerveH44
Copy link
Contributor Author

The gates are commons I think. They are treated as so. You would like another sort by CMC ?

@ZeldaZach
Copy link
Member

It’s a pointless case. They’re fine being in the commons area. Doesn’t have to be first.

@ZeldaZach ZeldaZach merged commit b0e36b4 into master Feb 20, 2019
@ZeldaZach ZeldaZach deleted the sort_by_rarity branch February 20, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HerveH44 @tooomm @ZeldaZach